Checkstyle Results
The following document contains the results of
Checkstyle.
Summary
| Files | Infos | Warnings | Errors |
|---|
| 86 | 0 | 0 | 893 |
Files
aigames/soccer/InvalidMoveException.java
| Error | Line |
|---|
| Line does not match expected header line of 'AI Soccer Project - network gaming environment for AI warriors.'. |
1
|
|
| Line is longer than 80 characters. |
26
|
|
| First sentence should end with a period. |
29
|
|
| Parameter message should be final. |
33
|
aigames/soccer/Move.java
| Error | Line |
|---|
|
| Line does not match expected header line of 'AI Soccer Project - network gaming environment for AI warriors.'. |
1
|
|
| Missing a Javadoc comment. |
33
|
|
| Name 'translationMap' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
33
|
|
| '3' is a magic number. |
42
|
|
| '4' is a magic number. |
45
|
|
| '5' is a magic number. |
48
|
|
| '6' is a magic number. |
51
|
|
| '7' is a magic number. |
54
|
|
| '8' is a magic number. |
57
|
|
| '{' is followed by whitespace. |
60
|
|
| '{' is followed by whitespace. |
61
|
|
| '{' is followed by whitespace. |
62
|
|
| '{' is followed by whitespace. |
63
|
|
| '{' is followed by whitespace. |
64
|
|
| '{' is followed by whitespace. |
65
|
|
| '{' is followed by whitespace. |
66
|
|
| '{' is followed by whitespace. |
67
|
|
| Missing a Javadoc comment. |
70
|
|
| Parameter steps should be final. |
77
|
|
| 'steps' hides a field. |
77
|
|
| Parameter steps should be final. |
86
|
|
| 'steps' hides a field. |
86
|
|
| Parameter direction should be final. |
95
|
|
| Method 'addStepSequence' is not designed for extension - needs to be abstract, final or empty. |
104
|
|
| Parameter steps should be final. |
104
|
|
| 'steps' hides a field. |
104
|
|
| Method 'addStep' is not designed for extension - needs to be abstract, final or empty. |
115
|
|
| Parameter step should be final. |
115
|
|
| Method 'addStep' is not designed for extension - needs to be abstract, final or empty. |
128
|
|
| Parameter step should be final. |
128
|
|
| Method 'addStepSequence' is not designed for extension - needs to be abstract, final or empty. |
137
|
|
| Parameter steps should be final. |
137
|
|
| 'steps' hides a field. |
137
|
|
| Method 'getSteps' is not designed for extension - needs to be abstract, final or empty. |
147
|
aigames/soccer/application/LogMessageBuilder.java
| Error | Line |
|---|
|
| Line does not match expected header line of 'AI Soccer Project - network gaming environment for AI warriors.'. |
1
|
|
| Missing a Javadoc comment. |
40
|
|
| Missing a Javadoc comment. |
41
|
|
| Method 'addMove' is not designed for extension - needs to be abstract, final or empty. |
57
|
|
| Method 'addName' is not designed for extension - needs to be abstract, final or empty. |
73
|
|
| Method 'addMap' is not designed for extension - needs to be abstract, final or empty. |
84
|
|
| Method 'addBegin' is not designed for extension - needs to be abstract, final or empty. |
97
|
|
| Method 'addWinner' is not designed for extension - needs to be abstract, final or empty. |
106
|
|
| Expected @param tag for 'name'. |
106
|
|
| Method 'addError' is not designed for extension - needs to be abstract, final or empty. |
116
|
|
| Method 'addTextElement' is not designed for extension - needs to be abstract, final or empty. |
128
|
|
| Method 'getMessage' is not designed for extension - needs to be abstract, final or empty. |
138
|
aigames/soccer/application/Message.java
| Error | Line |
|---|
|
| Line does not match expected header line of 'AI Soccer Project - network gaming environment for AI warriors.'. |
1
|
|
| First sentence should end with a period. |
44
|
|
| First sentence should end with a period. |
47
|
|
| First sentence should end with a period. |
50
|
|
| First sentence should end with a period. |
53
|
|
| First sentence should end with a period. |
56
|
|
| First sentence should end with a period. |
59
|
|
| First sentence should end with a period. |
62
|
|
| Missing a Javadoc comment. |
64
|
|
| Missing a Javadoc comment. |
65
|
|
| Missing a Javadoc comment. |
66
|
|
| Missing a Javadoc comment. |
67
|
|
| Missing a Javadoc comment. |
68
|
|
| Missing a Javadoc comment. |
69
|
|
| Missing a Javadoc comment. |
70
|
|
| Missing a Javadoc comment. |
71
|
|
| Missing a Javadoc comment. |
72
|
|
| Parameter userId should be final. |
79
|
|
| 'userId' hides a field. |
79
|
|
| Parameter message should be final. |
79
|
|
| 'message' hides a field. |
79
|
|
| Method 'getLastValidationReason' is not designed for extension - needs to be abstract, final or empty. |
128
|
|
| Method 'getMessageId' is not designed for extension - needs to be abstract, final or empty. |
136
|
|
| Method 'getMessageType' is not designed for extension - needs to be abstract, final or empty. |
145
|
|
| Method 'getMessage' is not designed for extension - needs to be abstract, final or empty. |
153
|
|
| Method 'validate' is not designed for extension - needs to be abstract, final or empty. |
162
|
|
| Parameter validator should be final. |
162
|
|
| Method 'getUserId' is not designed for extension - needs to be abstract, final or empty. |
179
|
|
| Method 'getMessageIdAsString' is not designed for extension - needs to be abstract, final or empty. |
187
|
|
| Method 'getSendDate' is not designed for extension - needs to be abstract, final or empty. |
195
|
|
| Method 'setSendDate' is not designed for extension - needs to be abstract, final or empty. |
203
|
|
| Parameter sendDate should be final. |
203
|
|
| 'sendDate' hides a field. |
203
|
|
| Method 'incResendCounter' is not designed for extension - needs to be abstract, final or empty. |
210
|
|
| Method 'getMove' is not designed for extension - needs to be abstract, final or empty. |
218
|
aigames/soccer/application/MessageSender.java
| Error | Line |
|---|
|
| Line does not match expected header line of 'AI Soccer Project - network gaming environment for AI warriors.'. |
1
|
|
| Missing a Javadoc comment. |
47
|
|
| Name 'ACCEPTED_TEMPLATE' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
47
|
|
| Missing a Javadoc comment. |
48
|
|
| Name 'REFUSED_TEMPLATE' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
48
|
|
| Missing a Javadoc comment. |
49
|
|
| Name 'PARAMS_TEMPLATE' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
49
|
|
| Missing a Javadoc comment. |
50
|
|
| Name 'GAME_OVER_TEMPLATE' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
50
|
|
| Missing a Javadoc comment. |
51
|
|
| '+' should be on a new line. |
55
|
|
| '+' should be on a new line. |
59
|
|
| '+' should be on a new line. |
62
|
|
| '+' should be on a new line. |
63
|
|
| '+' should be on a new line. |
66
|
|
| Missing a Javadoc comment. |
70
|
|
| Missing a Javadoc comment. |
71
|
|
| Line is longer than 80 characters. |
72
|
|
| Missing a Javadoc comment. |
72
|
|
| Missing a Javadoc comment. |
73
|
|
| Parameter server should be final. |
79
|
|
| 'server' hides a field. |
79
|
|
| Method 'getCounter' is not designed for extension - needs to be abstract, final or empty. |
87
|
|
| Missing a Javadoc comment. |
93
|
|
| Parameter body should be final. |
93
|
|
| Must have at least one statement. |
98
|
|
| Method 'sendGameParameters' is not designed for extension - needs to be abstract, final or empty. |
114
|
|
| Parameter userId should be final. |
114
|
|
| Parameter width should be final. |
114
|
|
| Parameter height should be final. |
114
|
|
| Parameter goal should be final. |
115
|
|
| Parameter side should be final. |
115
|
|
| Parameter begin should be final. |
115
|
|
| Line is longer than 80 characters. |
120
|
|
| Line is longer than 80 characters. |
124
|
|
| Line is longer than 80 characters. |
126
|
|
| Missing a Javadoc comment. |
132
|
|
| Missing a Javadoc comment. |
136
|
|
| Parameter userId should be final. |
136
|
|
| Parameter messageId should be final. |
136
|
|
| Parameter message should be final. |
136
|
|
| Method 'sendRefused' is not designed for extension - needs to be abstract, final or empty. |
150
|
|
| Parameter message should be final. |
150
|
|
| Parameter reason should be final. |
150
|
|
| Missing a Javadoc comment. |
156
|
|
| Parameter message should be final. |
156
|
|
| Parameter confirmation should be final. |
156
|
|
| Line is longer than 80 characters. |
157
|
|
| Method 'sendAccepted' is not designed for extension - needs to be abstract, final or empty. |
165
|
|
| Parameter message should be final. |
165
|
|
| Method 'sendGameOver' is not designed for extension - needs to be abstract, final or empty. |
175
|
|
| Parameter winner should be final. |
175
|
|
| Parameter userId should be final. |
175
|
|
| Method 'checkConfirmationTimeouts' is not designed for extension - needs to be abstract, final or empty. |
184
|
|
| Method 'setMessageConfirmation' is not designed for extension - needs to be abstract, final or empty. |
208
|
|
| Parameter confirmationMessage should be final. |
208
|
|
| Method 'forwardIncoming' is not designed for extension - needs to be abstract, final or empty. |
224
|
|
| Parameter message should be final. |
224
|
|
| Parameter userId should be final. |
224
|
|
| Method 'sendWithConfirmation' is not designed for extension - needs to be abstract, final or empty. |
234
|
|
| Parameter userId should be final. |
234
|
|
| Parameter messageToSend should be final. |
234
|
|
| Method 'areUnconfirmedMessages' is not designed for extension - needs to be abstract, final or empty. |
246
|
|
| Method 'clearUnconfirmedMessages' is not designed for extension - needs to be abstract, final or empty. |
253
|
|
| Method 'sendLogGameOver' is not designed for extension - needs to be abstract, final or empty. |
262
|
|
| Parameter winner should be final. |
262
|
|
| Parameter id should be final. |
262
|
|
| Method 'sendLogMove' is not designed for extension - needs to be abstract, final or empty. |
274
|
|
| Parameter move should be final. |
274
|
|
| Parameter id should be final. |
274
|
|
| Parameter date should be final. |
274
|
aigames/soccer/application/SoccerApp.java
| Error | Line |
|---|
|
| Line does not match expected header line of 'AI Soccer Project - network gaming environment for AI warriors.'. |
1
|
|
| Missing a Javadoc comment. |
64
|
|
| Missing a Javadoc comment. |
65
|
|
| Missing a Javadoc comment. |
66
|
|
| Missing a Javadoc comment. |
67
|
|
| Missing a Javadoc comment. |
68
|
|
| Missing a Javadoc comment. |
69
|
|
| Missing a Javadoc comment. |
70
|
|
| Missing a Javadoc comment. |
71
|
|
| Missing a Javadoc comment. |
72
|
|
| Missing a Javadoc comment. |
73
|
|
| Missing a Javadoc comment. |
74
|
|
| Missing a Javadoc comment. |
75
|
|
| Missing a Javadoc comment. |
76
|
|
| Missing a Javadoc comment. |
77
|
|
| Missing a Javadoc comment. |
78
|
|
| Line is longer than 80 characters. |
79
|
|
| Missing a Javadoc comment. |
79
|
|
| Missing a Javadoc comment. |
80
|
|
| Missing a Javadoc comment. |
81
|
|
| Line is longer than 80 characters. |
82
|
|
| Missing a Javadoc comment. |
82
|
|
| Missing a Javadoc comment. |
83
|
|
| Missing a Javadoc comment. |
84
|
|
| Missing a Javadoc comment. |
85
|
|
| Missing a Javadoc comment. |
86
|
|
| Missing a Javadoc comment. |
87
|
|
| Missing a Javadoc comment. |
88
|
|
| Missing a Javadoc comment. |
89
|
|
| Missing a Javadoc comment. |
90
|
|
| Missing a Javadoc comment. |
91
|
|
| Missing a Javadoc comment. |
92
|
|
| Method 'configure' is not designed for extension - needs to be abstract, final or empty. |
97
|
|
| Parameter isUnique should be final. |
97
|
|
| Method 'setServer' is not designed for extension - needs to be abstract, final or empty. |
133
|
|
| Line is longer than 80 characters. |
141
|
|
| Method 'unregisterUser' is not designed for extension - needs to be abstract, final or empty. |
141
|
|
| Line is longer than 80 characters. |
163
|
|
| Method 'receiveMessage' is not designed for extension - needs to be abstract, final or empty. |
165
|
|
| Line is longer than 80 characters. |
184
|
|
| Missing a Javadoc comment. |
193
|
|
| Must have at least one statement. |
200
|
|
| Method 'run' is not designed for extension - needs to be abstract, final or empty. |
213
|
|
| Missing a Javadoc comment. |
259
|
|
| Missing a Javadoc comment. |
271
|
|
| Must have at least one statement. |
279
|
|
| Missing a Javadoc comment. |
290
|
|
| Parameter message should be final. |
290
|
|
| Missing a Javadoc comment. |
318
|
|
| Parameter thisPlayer should be final. |
318
|
|
| '&&' should be on a new line. |
324
|
|
| Missing a Javadoc comment. |
334
|
|
| Parameter message should be final. |
334
|
|
| 'goal' hides a field. |
345
|
|
| '+' should be on a new line. |
367
|
|
| Missing a Javadoc comment. |
379
|
|
| Parameter pos should be final. |
379
|
|
| Missing a Javadoc comment. |
400
|
|
| Parameter message should be final. |
400
|
|
| Parameter observerOnly should be final. |
400
|
|
| Parameter moveDate should be final. |
401
|
|
| Missing a Javadoc comment. |
428
|
|
| Parameter winner should be final. |
428
|
|
| Missing a Javadoc comment. |
452
|
|
| Missing a Javadoc comment. |
461
|
|
| Parameter userInfo should be final. |
461
|
|
| Missing a Javadoc comment. |
494
|
|
| Parameter i should be final. |
494
|
|
| Missing a Javadoc comment. |
500
|
|
| Parameter toPlayers should be final. |
500
|
|
| Method 'registerUser' is not designed for extension - needs to be abstract, final or empty. |
537
|
|
| Parameter userId should be final. |
537
|
|
| Parameter message should be final. |
537
|
|
| '&&' should be on a new line. |
543
|
|
| '&&' should be on a new line. |
548
|
|
| '&&' should be on a new line. |
550
|
|
| '||' should be on a new line. |
551
|
aigames/soccer/application/UserInfo.java
| Error | Line |
|---|
|
| Line does not match expected header line of 'AI Soccer Project - network gaming environment for AI warriors.'. |
1
|
|
| First sentence should end with a period. |
35
|
|
| First sentence should end with a period. |
38
|
|
| First sentence should end with a period. |
41
|
|
| Missing a Javadoc comment. |
43
|
|
| Missing a Javadoc comment. |
44
|
|
| Missing a Javadoc comment. |
45
|
|
| Missing a Javadoc comment. |
46
|
|
| Missing a Javadoc comment. |
47
|
|
| Parameter userId should be final. |
53
|
|
| 'userId' hides a field. |
53
|
|
| Parameter userId should be final. |
62
|
|
| 'userId' hides a field. |
62
|
|
| Parameter message should be final. |
62
|
|
| 'type' hides a field. |
65
|
|
| Method 'getType' is not designed for extension - needs to be abstract, final or empty. |
80
|
|
| Method 'setType' is not designed for extension - needs to be abstract, final or empty. |
88
|
|
| Parameter type should be final. |
88
|
|
| 'type' hides a field. |
88
|
|
| Method 'getLastMessageDate' is not designed for extension - needs to be abstract, final or empty. |
96
|
|
| Method 'setLastMessageDate' is not designed for extension - needs to be abstract, final or empty. |
104
|
|
| Parameter lastMessageDate should be final. |
104
|
|
| 'lastMessageDate' hides a field. |
104
|
|
| Method 'getName' is not designed for extension - needs to be abstract, final or empty. |
112
|
|
| Method 'setName' is not designed for extension - needs to be abstract, final or empty. |
120
|
|
| Parameter name should be final. |
120
|
|
| 'name' hides a field. |
120
|
|
| Method 'getNoOfBadMessages' is not designed for extension - needs to be abstract, final or empty. |
128
|
|
| Method 'setNoOfBadMessages' is not designed for extension - needs to be abstract, final or empty. |
136
|
|
| Parameter noOfBadMessages should be final. |
136
|
|
| 'noOfBadMessages' hides a field. |
136
|
|
| Method 'getUserId' is not designed for extension - needs to be abstract, final or empty. |
144
|
aigames/soccer/application/Validator.java
| Error | Line |
|---|
|
| Line does not match expected header line of 'AI Soccer Project - network gaming environment for AI warriors.'. |
1
|
|
| Missing a Javadoc comment. |
49
|
|
| Missing a Javadoc comment. |
50
|
|
| Missing a Javadoc comment. |
51
|
|
| Line is longer than 80 characters. |
56
|
|
| Parameter schemaFileName should be final. |
60
|
|
| Parameter e should be final. |
77
|
|
| Parameter e should be final. |
82
|
|
| Parameter e should be final. |
86
|
|
| Method 'validate' is not designed for extension - needs to be abstract, final or empty. |
99
|
|
| Parameter message should be final. |
99
|
|
| Expected @param tag for 'message'. |
99
|
|
| Method 'getStatus' is not designed for extension - needs to be abstract, final or empty. |
113
|
aigames/soccer/communication/ClientData.java
| Error | Line |
|---|
|
| Line does not match expected header line of 'AI Soccer Project - network gaming environment for AI warriors.'. |
1
|
|
| Missing a Javadoc comment. |
32
|
|
| Missing a Javadoc comment. |
33
|
|
| Missing a Javadoc comment. |
34
|
|
| Parameter socket should be final. |
41
|
|
| 'socket' hides a field. |
41
|
|
| Parameter userId should be final. |
41
|
|
| 'userId' hides a field. |
41
|
|
| Method 'append' is not designed for extension - needs to be abstract, final or empty. |
51
|
|
| Parameter message should be final. |
51
|
|
| Method 'getBuffer' is not designed for extension - needs to be abstract, final or empty. |
59
|
|
| Method 'getSocket' is not designed for extension - needs to be abstract, final or empty. |
67
|
|
| Method 'getUserId' is not designed for extension - needs to be abstract, final or empty. |
75
|
|
| Method 'clearBuffer' is not designed for extension - needs to be abstract, final or empty. |
83
|
|
| Parameter position should be final. |
83
|
aigames/soccer/communication/SocketCommModule.java
| Error | Line |
|---|
|
| Line does not match expected header line of 'AI Soccer Project - network gaming environment for AI warriors.'. |
1
|
|
| Missing a Javadoc comment. |
68
|
|
| Name 'EOT' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
68
|
|
| Missing a Javadoc comment. |
69
|
|
| Missing a Javadoc comment. |
70
|
|
| Missing a Javadoc comment. |
71
|
|
| Missing a Javadoc comment. |
72
|
|
| Missing a Javadoc comment. |
73
|
|
| Missing a Javadoc comment. |
74
|
|
| Missing a Javadoc comment. |
75
|
|
| Missing a Javadoc comment. |
76
|
|
| '9669' is a magic number. |
76
|
|
| Missing a Javadoc comment. |
77
|
|
| Missing a Javadoc comment. |
78
|
|
| Line is longer than 80 characters. |
88
|
|
| Method 'configure' is not designed for extension - needs to be abstract, final or empty. |
90
|
|
| Parameter configuration should be final. |
90
|
|
| Parameter commModuleId should be final. |
90
|
|
| Method 'setServer' is not designed for extension - needs to be abstract, final or empty. |
101
|
|
| Parameter server should be final. |
101
|
|
| 'server' hides a field. |
101
|
|
| Line is longer than 80 characters. |
107
|
|
| Method 'sendMessage' is not designed for extension - needs to be abstract, final or empty. |
109
|
|
| Parameter userId should be final. |
109
|
|
| Parameter message should be final. |
109
|
|
| '+' should be on a new line. |
112
|
|
| '+' should be on a new line. |
131
|
|
| Line is longer than 80 characters. |
141
|
|
| Method 'disconnectUser' is not designed for extension - needs to be abstract, final or empty. |
143
|
|
| Parameter userId should be final. |
143
|
|
| Line has trailing spaces. |
149
|
|
| Line is longer than 80 characters. |
149
|
|
| Line contains a tab character. |
149
|
|
| Method 'shutdown' is not designed for extension - needs to be abstract, final or empty. |
161
|
|
| Method 'run' is not designed for extension - needs to be abstract, final or empty. |
168
|
|
| '+' should be on a new line. |
194
|
|
| Must have at least one statement. |
199
|
|
| Must have at least one statement. |
201
|
|
| Line has trailing spaces. |
220
|
|
| Line is longer than 80 characters. |
220
|
|
| Line contains a tab character. |
220
|
|
| '+' should be on a new line. |
227
|
|
| Must have at least one statement. |
246
|
|
| Must have at least one statement. |
248
|
|
| Missing a Javadoc comment. |
257
|
|
| Missing a Javadoc comment. |
282
|
|
| Parameter socket should be final. |
282
|
|
| Missing a Javadoc comment. |
303
|
|
| Parameter socket should be final. |
303
|
|
| Parameter selector should be final. |
304
|
|
| Missing a Javadoc comment. |
320
|
|
| Parameter client should be final. |
320
|
|
| Name 'BUFFER_SIZE' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
321
|
|
| '4096' is a magic number. |
321
|
|
| Parameter buffer should be final. |
349
|
|
| Missing a Javadoc comment. |
364
|
|
| Parameter message should be final. |
364
|
|
| Parameter data should be final. |
364
|
|
| '+' should be on a new line. |
365
|
|
| '+' should be on a new line. |
389
|
|
| '+' should be on a new line. |
393
|
|
| '+' should be on a new line. |
399
|
|
| Method 'setTest' is not designed for extension - needs to be abstract, final or empty. |
413
|
|
| Parameter b should be final. |
413
|
|
| Expected @param tag for 'b'. |
413
|
aigames/soccer/field/BasicGameField.java
| Error | Line |
|---|
|
| Line does not match expected header line of 'AI Soccer Project - network gaming environment for AI warriors.'. |
1
|
|
| Missing a Javadoc comment. |
43
|
|
| Missing a Javadoc comment. |
44
|
|
| Missing a Javadoc comment. |
45
|
|
| Line is longer than 80 characters. |
46
|
|
| Missing a Javadoc comment. |
46
|
|
| Missing a Javadoc comment. |
47
|
|
| Missing a Javadoc comment. |
48
|
|
| Parameter fieldConstructor should be final. |
54
|
|
| 'fieldConstructor' hides a field. |
54
|
|
| Method 'makeMove' is not designed for extension - needs to be abstract, final or empty. |
61
|
|
| Parameter move should be final. |
61
|
|
| Parameter color should be final. |
61
|
|
| '4' is a magic number. |
83
|
|
| '4' is a magic number. |
90
|
|
| Line is longer than 80 characters. |
93
|
|
| Missing a Javadoc comment. |
115
|
|
| Parameter integerMap should be final. |
115
|
|
| Parameter color should be final. |
115
|
|
| Parameter i should be final. |
115
|
|
| Method 'isDeadLock' is not designed for extension - needs to be abstract, final or empty. |
130
|
|
| Missing a Javadoc comment. |
134
|
|
| Parameter point should be final. |
134
|
|
| Parameter visitedPoints should be final. |
134
|
|
| '+' should be on a new line. |
141
|
|
| '4' is a magic number. |
149
|
|
| '5' is a magic number. |
161
|
|
| '8' is a magic number. |
161
|
|
| Line is longer than 80 characters. |
167
|
|
| '4' is a magic number. |
167
|
|
| Missing a Javadoc comment. |
182
|
|
| Parameter point should be final. |
182
|
|
| '4' is a magic number. |
187
|
|
| '5' is a magic number. |
193
|
|
| '8' is a magic number. |
193
|
|
| Missing a Javadoc comment. |
202
|
|
| Parameter point should be final. |
202
|
|
| Parameter direction should be final. |
202
|
|
| Line is longer than 80 characters. |
209
|
|
| '4' is a magic number. |
209
|
|
| Missing a Javadoc comment. |
219
|
|
| Parameter point should be final. |
219
|
|
| '4' is a magic number. |
224
|
|
| '5' is a magic number. |
233
|
|
| '8' is a magic number. |
233
|
|
| Missing a Javadoc comment. |
245
|
|
| Parameter currentPoint should be final. |
245
|
|
| Parameter step should be final. |
245
|
|
| Method 'getCurrentPosition' is not designed for extension - needs to be abstract, final or empty. |
256
|
|
| Method 'startGame' is not designed for extension - needs to be abstract, final or empty. |
263
|
|
| Method 'isGoal' is not designed for extension - needs to be abstract, final or empty. |
271
|
|
| Method 'isGameOver' is not designed for extension - needs to be abstract, final or empty. |
278
|
|
| '||' should be on a new line. |
279
|
|
| Method 'getNumberOfMoves' is not designed for extension - needs to be abstract, final or empty. |
286
|
|
| Parameter color should be final. |
286
|
|
| Avoid inline conditionals. |
289
|
|
| Method 'getAvgMoveLength' is not designed for extension - needs to be abstract, final or empty. |
295
|
|
| Parameter color should be final. |
295
|
|
| Method 'getFieldPoint' is not designed for extension - needs to be abstract, final or empty. |
316
|
|
| Parameter x should be final. |
316
|
|
| Parameter y should be final. |
316
|
|
| Method 'getMaximumXIndex' is not designed for extension - needs to be abstract, final or empty. |
323
|
|
| Method 'getMaximumYIndex' is not designed for extension - needs to be abstract, final or empty. |
330
|
aigames/soccer/field/FieldPoint.java
| Error | Line |
|---|
|
| Line does not match expected header line of 'AI Soccer Project - network gaming environment for AI warriors.'. |
1
|
|
| First sentence should end with a period. |
27
|
|
| First sentence should end with a period. |
30
|
|
| First sentence should end with a period. |
33
|
|
| Missing a Javadoc comment. |
35
|
|
| Parameter edges should be final. |
41
|
|
| 'edges' hides a field. |
41
|
|
| '4' is a magic number. |
42
|
|
| '{' is followed by whitespace. |
53
|
|
| Method 'setEdgeColor' is not designed for extension - needs to be abstract, final or empty. |
61
|
|
| Parameter edgeNumber should be final. |
61
|
|
| Parameter color should be final. |
61
|
|
| Method 'setEdgeColor' is not designed for extension - needs to be abstract, final or empty. |
70
|
|
| Parameter edgeNumber should be final. |
70
|
|
| Parameter color should be final. |
70
|
|
| Method 'getEdgeColor' is not designed for extension - needs to be abstract, final or empty. |
79
|
|
| Parameter edgeNumber should be final. |
79
|
aigames/soccer/field/GameField.java
| Error | Line |
|---|
|
| Line does not match expected header line of 'AI Soccer Project - network gaming environment for AI warriors.'. |
1
|
|
| Redundant 'public' modifier. |
40
|
|
| Redundant 'public' modifier. |
46
|
|
| Redundant 'public' modifier. |
52
|
|
| Redundant 'public' modifier. |
58
|
|
| Redundant 'public' modifier. |
64
|
|
| Redundant 'public' modifier. |
70
|
|
| Redundant 'public' modifier. |
77
|
|
| Redundant 'public' modifier. |
84
|
|
| Redundant 'public' modifier. |
92
|
|
| Redundant 'public' modifier. |
98
|
|
| Redundant 'public' modifier. |
104
|
aigames/soccer/field/constructor/Constructor.java
| Error | Line |
|---|
|
| Line does not match expected header line of 'AI Soccer Project - network gaming environment for AI warriors.'. |
1
|
|
| Redundant 'public' modifier. |
36
|
|
| Redundant 'public' modifier. |
42
|
|
| Redundant 'public' modifier. |
49
|
|
| Redundant 'public' modifier. |
56
|
aigames/soccer/field/constructor/StandardConstructor.java
| Error | Line |
|---|
|
| Line does not match expected header line of 'AI Soccer Project - network gaming environment for AI warriors.'. |
1
|
|
| Line is longer than 80 characters. |
32
|
|
| Missing a Javadoc comment. |
35
|
|
| Missing a Javadoc comment. |
36
|
|
| Missing a Javadoc comment. |
37
|
|
| Missing a Javadoc comment. |
38
|
|
| Parameter width should be final. |
47
|
|
| Parameter height should be final. |
47
|
|
| Parameter goal should be final. |
47
|
|
| Redundant throws: 'IllegalArgumentException' is unchecked exception. |
48
|
|
| '||' should be on a new line. |
53
|
|
| Method 'getNewField' is not designed for extension - needs to be abstract, final or empty. |
71
|
|
| '3' is a magic number. |
72
|
|
| 'for' construct must use '{}'s. |
122
|
|
| Line is longer than 80 characters. |
181
|
|
| Line is longer than 80 characters. |
187
|
|
| Method 'getStartingPosition' is not designed for extension - needs to be abstract, final or empty. |
221
|
|
| Line is longer than 80 characters. |
226
|
|
| Method 'isGameOverPosition' is not designed for extension - needs to be abstract, final or empty. |
228
|
|
| Parameter position should be final. |
228
|
|
| Method 'isGoalPosition' is not designed for extension - needs to be abstract, final or empty. |
235
|
|
| Parameter position should be final. |
235
|
aigames/soccer/observer/Communication.java
| Error | Line |
|---|
|
| Line does not match expected header line of 'AI Soccer Project - network gaming environment for AI warriors.'. |
1
|
|
| Missing a Javadoc comment. |
47
|
|
| Missing a Javadoc comment. |
50
|
|
| Missing a Javadoc comment. |
53
|
|
| Name 'EOT' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
53
|
|
| Missing a Javadoc comment. |
54
|
|
| Name 'ACCEPTED' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
54
|
|
| '101' is a magic number. |
54
|
|
| Missing a Javadoc comment. |
55
|
|
| Name 'NOT_ACCEPTED' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
55
|
|
| '202' is a magic number. |
55
|
|
| Missing a Javadoc comment. |
56
|
|
| Name 'REFUSED' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
56
|
|
| '303' is a magic number. |
56
|
|
| Missing a Javadoc comment. |
57
|
|
| Missing a Javadoc comment. |
58
|
|
| Missing a Javadoc comment. |
59
|
|
| Missing a Javadoc comment. |
60
|
|
| Missing a Javadoc comment. |
61
|
|
| Missing a Javadoc comment. |
62
|
|
| Method 'connect' is not designed for extension - needs to be abstract, final or empty. |
70
|
|
| Parameter ip should be final. |
70
|
|
| Expected @param tag for 'ip'. |
70
|
|
| Parameter port should be final. |
70
|
|
| Expected @param tag for 'port'. |
70
|
|
| Method 'disconnect' is not designed for extension - needs to be abstract, final or empty. |
91
|
|
| Method 'sayHello' is not designed for extension - needs to be abstract, final or empty. |
107
|
|
| Parameter name should be final. |
107
|
|
| '3' is a magic number. |
122
|
|
| Method 'readMessage' is not designed for extension - needs to be abstract, final or empty. |
131
|
|
| Parameter confirm should be final. |
131
|
|
| Expression can be simplified. |
138
|
|
| '100' is a magic number. |
139
|
|
| Method 'getGamesList' is not designed for extension - needs to be abstract, final or empty. |
181
|
|
| '3' is a magic number. |
183
|
|
| Parameter name should be final. |
195
|
|
| Parameter message should be final. |
203
|
|
| Parameter id should be final. |
229
|
|
| Method 'setObserver' is not designed for extension - needs to be abstract, final or empty. |
259
|
|
| Parameter observer should be final. |
259
|
|
| 'observer' hides a field. |
259
|
|
| Expected @param tag for 'observer'. |
259
|
|
| Method 'shutdown' is not designed for extension - needs to be abstract, final or empty. |
266
|
|
| Method 'run' is not designed for extension - needs to be abstract, final or empty. |
273
|
aigames/soccer/observer/FieldPanel.java
| Error | Line |
|---|
|
| Line does not match expected header line of 'AI Soccer Project - network gaming environment for AI warriors.'. |
1
|
|
| Missing a Javadoc comment. |
33
|
|
| Method 'setImage' is not designed for extension - needs to be abstract, final or empty. |
47
|
|
| Parameter buffer should be final. |
47
|
|
| 'buffer' hides a field. |
47
|
|
| Expected @param tag for 'buffer'. |
47
|
|
| Method 'paintComponent' is not designed for extension - needs to be abstract, final or empty. |
54
|
|
| Parameter g should be final. |
54
|
aigames/soccer/observer/Observer.java
| Error | Line |
|---|
|
| Line does not match expected header line of 'AI Soccer Project - network gaming environment for AI warriors.'. |
1
|
|
| Missing a Javadoc comment. |
69
|
|
| Missing a Javadoc comment. |
70
|
|
| '204' is a magic number. |
70
|
|
| Missing a Javadoc comment. |
71
|
|
| Missing a Javadoc comment. |
72
|
|
| Missing a Javadoc comment. |
73
|
|
| Missing a Javadoc comment. |
74
|
|
| Missing a Javadoc comment. |
75
|
|
| Missing a Javadoc comment. |
76
|
|
| Missing a Javadoc comment. |
77
|
|
| Missing a Javadoc comment. |
78
|
|
| Missing a Javadoc comment. |
79
|
|
| Missing a Javadoc comment. |
80
|
|
| Missing a Javadoc comment. |
81
|
|
| Missing a Javadoc comment. |
82
|
|
| Missing a Javadoc comment. |
83
|
|
| Missing a Javadoc comment. |
84
|
|
| Missing a Javadoc comment. |
85
|
|
| Missing a Javadoc comment. |
86
|
|
| Missing a Javadoc comment. |
87
|
|
| Parameter args should be final. |
102
|
|
| Expected @param tag for 'args'. |
102
|
|
| '750' is a magic number. |
113
|
|
| '400' is a magic number. |
113
|
|
| Parameter e should be final. |
118
|
|
| Line is longer than 80 characters. |
189
|
|
| Line is longer than 80 characters. |
190
|
|
| Parameter e should be final. |
190
|
|
| '20' is a magic number. |
212
|
|
| Parameter value should be final. |
224
|
|
| Line has trailing spaces. |
240
|
|
| '100' is a magic number. |
256
|
|
| Must have at least one statement. |
258
|
|
| Must have at least one statement. |
269
|
|
| Missing a Javadoc comment. |
275
|
|
| Method 'processMessage' is not designed for extension - needs to be abstract, final or empty. |
296
|
|
| Parameter doc should be final. |
296
|
|
| Line is longer than 80 characters. |
318
|
|
| Must have at least one statement. |
349
|
|
| Missing a Javadoc comment. |
365
|
|
| Parameter time should be final. |
365
|
|
| '3600' is a magic number. |
371
|
|
| '1000' is a magic number. |
371
|
|
| '3600' is a magic number. |
379
|
|
| '1000' is a magic number. |
379
|
|
| Missing a Javadoc comment. |
385
|
|
| Parameter node should be final. |
385
|
|
| Line is longer than 80 characters. |
395
|
|
| Missing a Javadoc comment. |
418
|
|
| '5' is a magic number. |
446
|
|
| Missing a Javadoc comment. |
468
|
|
| Parameter begin should be final. |
468
|
|
| Parameter end should be final. |
468
|
|
| Parameter edgeColor should be final. |
468
|
|
| Parameter g should be final. |
468
|
|
| '-2' is a magic number. |
471
|
|
| '255' is a magic number. |
479
|
|
| '255' is a magic number. |
481
|
|
| '20' is a magic number. |
486
|
aigames/soccer/observer/OptionsPane.java
| Error | Line |
|---|
|
| Line does not match expected header line of 'AI Soccer Project - network gaming environment for AI warriors.'. |
1
|
|
| Missing a Javadoc comment. |
42
|
|
| '170' is a magic number. |
42
|
|
| Missing a Javadoc comment. |
43
|
|
| '187' is a magic number. |
43
|
|
| Missing a Javadoc comment. |
44
|
|
| '221' is a magic number. |
44
|
|
| Missing a Javadoc comment. |
45
|
|
| '238' is a magic number. |
45
|
|
| Missing a Javadoc comment. |
46
|
|
| Missing a Javadoc comment. |
47
|
|
| Missing a Javadoc comment. |
48
|
|
| Missing a Javadoc comment. |
49
|
|
| Missing a Javadoc comment. |
50
|
|
| Missing a Javadoc comment. |
51
|
|
| Missing a Javadoc comment. |
52
|
|
| Missing a Javadoc comment. |
53
|
|
| Missing a Javadoc comment. |
54
|
|
| Missing a Javadoc comment. |
55
|
|
| Missing a Javadoc comment. |
56
|
|
| Missing a Javadoc comment. |
57
|
|
| Missing a Javadoc comment. |
58
|
|
| Missing a Javadoc comment. |
59
|
|
| Missing a Javadoc comment. |
60
|
|
| Missing a Javadoc comment. |
61
|
|
| Missing a Javadoc comment. |
62
|
|
| Missing a Javadoc comment. |
63
|
|
| Missing a Javadoc comment. |
64
|
|
| Missing a Javadoc comment. |
65
|
|
| '5' is a magic number. |
102
|
|
| '10' is a magic number. |
105
|
|
| Line contains a tab character. |
121
|
|
| Line is longer than 80 characters. |
122
|
|
| Line contains a tab character. |
122
|
|
| Line contains a tab character. |
123
|
|
| Line contains a tab character. |
124
|
|
| Line contains a tab character. |
125
|
|
| Line contains a tab character. |
126
|
|
| '20' is a magic number. |
130
|
|
| '20' is a magic number. |
177
|
|
| '5' is a magic number. |
197
|
|
| Parameter e should be final. |
200
|
|
| '4' is a magic number. |
261
|
|
| Line is longer than 80 characters. |
268
|
|
| Parameter e should be final. |
270
|
|
| '5' is a magic number. |
291
|
|
| Parameter e should be final. |
294
|
|
| Method 'isConnected' is not designed for extension - needs to be abstract, final or empty. |
385
|
|
| Method 'setConnected' is not designed for extension - needs to be abstract, final or empty. |
393
|
|
| Parameter b should be final. |
393
|
|
| Expected @param tag for 'b'. |
393
|
|
| Method 'isSelected' is not designed for extension - needs to be abstract, final or empty. |
411
|
|
| Method 'setSelected' is not designed for extension - needs to be abstract, final or empty. |
419
|
|
| Parameter b should be final. |
419
|
|
| Expected @param tag for 'b'. |
419
|
|
| Method 'setGamesList' is not designed for extension - needs to be abstract, final or empty. |
437
|
|
| Parameter list should be final. |
437
|
|
| Expected @param tag for 'list'. |
437
|
|
| Method 'getGame' is not designed for extension - needs to be abstract, final or empty. |
451
|
|
| Method 'getIp' is not designed for extension - needs to be abstract, final or empty. |
459
|
|
| Method 'getPort' is not designed for extension - needs to be abstract, final or empty. |
467
|
aigames/soccer/observer/PlayerPanel.java
| Error | Line |
|---|
|
| Line does not match expected header line of 'AI Soccer Project - network gaming environment for AI warriors.'. |
1
|
|
| Missing a Javadoc comment. |
35
|
|
| '204' is a magic number. |
35
|
|
| '255' is a magic number. |
35
|
|
| '204' is a magic number. |
35
|
|
| Missing a Javadoc comment. |
36
|
|
| Missing a Javadoc comment. |
37
|
|
| Missing a Javadoc comment. |
38
|
|
| Missing a Javadoc comment. |
39
|
|
| Missing a Javadoc comment. |
40
|
|
| Missing a Javadoc comment. |
41
|
|
| '153' is a magic number. |
60
|
|
| Missing a Javadoc comment. |
66
|
|
| '5' is a magic number. |
71
|
|
| Missing a Javadoc comment. |
80
|
|
| Line is longer than 80 characters. |
83
|
|
| '15' is a magic number. |
84
|
|
| '15' is a magic number. |
88
|
|
| '102' is a magic number. |
103
|
|
| '204' is a magic number. |
103
|
|
| '14' is a magic number. |
105
|
|
| '255' is a magic number. |
134
|
|
| '153' is a magic number. |
134
|
|
| '204' is a magic number. |
148
|
|
| '153' is a magic number. |
148
|
|
| Method 'setMovesAverage' is not designed for extension - needs to be abstract, final or empty. |
158
|
|
| Parameter number should be final. |
158
|
|
| Method 'setMovesTotal' is not designed for extension - needs to be abstract, final or empty. |
166
|
|
| Parameter number should be final. |
166
|
|
| Method 'setPlayerName' is not designed for extension - needs to be abstract, final or empty. |
174
|
|
| Parameter name should be final. |
174
|
|
| Method 'setTime' is not designed for extension - needs to be abstract, final or empty. |
182
|
|
| Parameter time should be final. |
182
|
|
| 'time' hides a field. |
182
|
snifos/Main.java
| Error | Line |
|---|
|
| Line does not match expected header line of 'AI Soccer Project - network gaming environment for AI warriors.'. |
1
|
|
| Utility classes should not have a public or default constructor. |
36
|
|
| Parameter args should be final. |
41
|
snifos/application/Application.java
| Error | Line |
|---|
|
| Line does not match expected header line of 'AI Soccer Project - network gaming environment for AI warriors.'. |
1
|
|
| Redundant 'public' modifier. |
47
|
|
| Redundant 'public' modifier. |
55
|
|
| Redundant 'public' modifier. |
64
|
|
| Redundant 'public' modifier. |
74
|
|
| Redundant 'public' modifier. |
86
|
snifos/application/ApplicationInfo.java
| Error | Line |
|---|
|
| Line does not match expected header line of 'AI Soccer Project - network gaming environment for AI warriors.'. |
1
|
|
| Missing a Javadoc comment. |
33
|
|
| Missing a Javadoc comment. |
34
|
|
| Missing a Javadoc comment. |
35
|
|
| Method 'getClassName' is not designed for extension - needs to be abstract, final or empty. |
42
|
|
| Method 'setClassName' is not designed for extension - needs to be abstract, final or empty. |
50
|
|
| Parameter className should be final. |
50
|
|
| 'className' hides a field. |
50
|
|
| Method 'getTypicalConfiguration' is not designed for extension - needs to be abstract, final or empty. |
58
|
|
| Method 'setTypicalConfiguration' is not designed for extension - needs to be abstract, final or empty. |
67
|
|
| Parameter typicalConfiguration should be final. |
67
|
|
| 'typicalConfiguration' hides a field. |
67
|
|
| Method 'getUniqueConfigurations' is not designed for extension - needs to be abstract, final or empty. |
77
|
|
| Method 'addUniqueConfiguration' is not designed for extension - needs to be abstract, final or empty. |
86
|
|
| Parameter uniqueConfiguration should be final. |
86
|
snifos/application/test/DummyApplication.java
| Error | Line |
|---|
|
| Line does not match expected header line of 'AI Soccer Project - network gaming environment for AI warriors.'. |
1
|
|
| Missing a Javadoc comment. |
53
|
|
| Missing a Javadoc comment. |
54
|
|
| Missing a Javadoc comment. |
55
|
|
| Missing a Javadoc comment. |
56
|
|
| Method 'configure' is not designed for extension - needs to be abstract, final or empty. |
68
|
|
| Parameter configuration should be final. |
68
|
|
| Parameter isUnique should be final. |
68
|
|
| Line is longer than 80 characters. |
70
|
|
| Method 'setServer' is not designed for extension - needs to be abstract, final or empty. |
79
|
|
| Parameter server should be final. |
79
|
|
| 'server' hides a field. |
79
|
|
| Method 'unregisterUser' is not designed for extension - needs to be abstract, final or empty. |
87
|
|
| Parameter userId should be final. |
87
|
|
| Method 'receiveMessage' is not designed for extension - needs to be abstract, final or empty. |
96
|
|
| Parameter userId should be final. |
96
|
|
| Parameter message should be final. |
96
|
|
| '+' should be on a new line. |
97
|
|
| Method 'registerUser' is not designed for extension - needs to be abstract, final or empty. |
132
|
|
| Parameter userId should be final. |
132
|
|
| Parameter message should be final. |
132
|
snifos/common/UserId.java
| Error | Line |
|---|
|
| Line does not match expected header line of 'AI Soccer Project - network gaming environment for AI warriors.'. |
1
|
|
| Missing a Javadoc comment. |
28
|
|
| Missing a Javadoc comment. |
29
|
|
| Missing a Javadoc comment. |
30
|
|
| Parameter commModuleId should be final. |
38
|
|
| 'commModuleId' hides a field. |
38
|
|
| Parameter userIdInModule should be final. |
38
|
|
| 'userIdInModule' hides a field. |
38
|
|
| Method 'equals' is not designed for extension - needs to be abstract, final or empty. |
50
|
|
| Parameter that should be final. |
50
|
|
| Avoid inline conditionals. |
51
|
|
| Method 'hashCode' is not designed for extension - needs to be abstract, final or empty. |
58
|
|
| Method 'toString' is not designed for extension - needs to be abstract, final or empty. |
66
|
|
| Method 'getCommModuleId' is not designed for extension - needs to be abstract, final or empty. |
75
|
|
| Method 'getUserId' is not designed for extension - needs to be abstract, final or empty. |
83
|
|
| Method 'getUserIdInModule' is not designed for extension - needs to be abstract, final or empty. |
92
|
snifos/common/test/DummyMessages.java
| Error | Line |
|---|
|
| Line does not match expected header line of 'AI Soccer Project - network gaming environment for AI warriors.'. |
1
|
|
| interfaces should describe a type and hence have methods. |
28
|
|
| First sentence should end with a period. |
29
|
|
| Redundant 'public' modifier. |
30
|
|
| Name 'requests' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
30
|
|
| '+' should be on a new line. |
31
|
|
| Line has trailing spaces. |
33
|
|
| '+' should be on a new line. |
34
|
|
| First sentence should end with a period. |
38
|
|
| Redundant 'public' modifier. |
39
|
|
| Name 'responses' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
39
|
|
| '+' should be on a new line. |
40
|
|
| Line has trailing spaces. |
42
|
|
| '+' should be on a new line. |
43
|
|
| '+' should be on a new line. |
44
|
snifos/communication/CommModule.java
| Error | Line |
|---|
|
| Line does not match expected header line of 'AI Soccer Project - network gaming environment for AI warriors.'. |
1
|
|
| Redundant 'public' modifier. |
45
|
|
| Redundant 'public' modifier. |
52
|
|
| Redundant 'public' modifier. |
61
|
|
| Redundant 'public' modifier. |
68
|
|
| Redundant 'public' modifier. |
73
|
snifos/communication/CommModuleInfo.java
| Error | Line |
|---|
|
| Line does not match expected header line of 'AI Soccer Project - network gaming environment for AI warriors.'. |
1
|
|
| Missing a Javadoc comment. |
33
|
|
| Missing a Javadoc comment. |
34
|
|
| Method 'setClassName' is not designed for extension - needs to be abstract, final or empty. |
47
|
|
| Parameter className should be final. |
47
|
|
| Line is longer than 80 characters. |
48
|
|
| Redundant throws: 'SecurityException' is unchecked exception. |
48
|
|
| Method 'setProperty' is not designed for extension - needs to be abstract, final or empty. |
57
|
|
| Parameter name should be final. |
57
|
|
| Parameter value should be final. |
57
|
|
| Method 'getProperties' is not designed for extension - needs to be abstract, final or empty. |
65
|
|
| Method 'getConstructor' is not designed for extension - needs to be abstract, final or empty. |
73
|
snifos/communication/test/DummyCommModule.java
| Error | Line |
|---|
|
| Line does not match expected header line of 'AI Soccer Project - network gaming environment for AI warriors.'. |
1
|
|
| Missing a Javadoc comment. |
56
|
|
| Missing a Javadoc comment. |
57
|
|
| Missing a Javadoc comment. |
58
|
|
| Missing a Javadoc comment. |
59
|
|
| Missing a Javadoc comment. |
60
|
|
| Variable 'responseCounter' must be private and have accessor methods. |
60
|
|
| Method 'configure' is not designed for extension - needs to be abstract, final or empty. |
72
|
|
| Parameter configuration should be final. |
72
|
|
| Parameter commModuleId should be final. |
72
|
|
| Method 'setServer' is not designed for extension - needs to be abstract, final or empty. |
81
|
|
| Parameter server should be final. |
81
|
|
| 'server' hides a field. |
81
|
|
| Method 'sendMessage' is not designed for extension - needs to be abstract, final or empty. |
89
|
|
| Parameter userId should be final. |
89
|
|
| Parameter message should be final. |
89
|
|
| '+' should be on a new line. |
90
|
|
| Line has trailing spaces. |
94
|
|
| Method 'disconnectUser' is not designed for extension - needs to be abstract, final or empty. |
114
|
|
| Parameter userId should be final. |
114
|
|
| '+' should be on a new line. |
115
|
|
| Method 'run' is not designed for extension - needs to be abstract, final or empty. |
129
|
|
| '7' is a magic number. |
134
|
|
| '3000' is a magic number. |
141
|
|
| '3000' is a magic number. |
141
|
|
| '100' is a magic number. |
146
|
|
| '+' should be on a new line. |
154
|
snifos/exception/ConfigurationException.java
| Error | Line |
|---|
|
| Line does not match expected header line of 'AI Soccer Project - network gaming environment for AI warriors.'. |
1
|
|
| Line is longer than 80 characters. |
25
|
|
| Parameter e should be final. |
32
|
|
| Parameter message should be final. |
47
|
snifos/exception/InvalidMessageException.java
| Error | Line |
|---|
|
| Line does not match expected header line of 'AI Soccer Project - network gaming environment for AI warriors.'. |
1
|
|
| Line is longer than 80 characters. |
25
|
|
| Parameter e should be final. |
32
|
snifos/exception/InvalidUserException.java
| Error | Line |
|---|
|
| Line does not match expected header line of 'AI Soccer Project - network gaming environment for AI warriors.'. |
1
|
|
| Line is longer than 80 characters. |
25
|
snifos/server/Server.java
| Error | Line |
|---|
|
| Line does not match expected header line of 'AI Soccer Project - network gaming environment for AI warriors.'. |
1
|
|
| Redundant 'public' modifier. |
41
|
|
| Redundant 'public' modifier. |
52
|
|
| Redundant 'public' modifier. |
59
|
|
| Redundant 'public' modifier. |
65
|
snifos/server/SnifosServer.java
| Error | Line |
|---|
|
| Line does not match expected header line of 'AI Soccer Project - network gaming environment for AI warriors.'. |
1
|
|
| Missing a Javadoc comment. |
63
|
|
| Line is longer than 80 characters. |
64
|
|
| Missing a Javadoc comment. |
64
|
|
| Missing a Javadoc comment. |
65
|
|
| Missing a Javadoc comment. |
66
|
|
| Missing a Javadoc comment. |
67
|
|
| Missing a Javadoc comment. |
68
|
|
| Missing a Javadoc comment. |
69
|
|
| Missing a Javadoc comment. |
70
|
|
| Missing a Javadoc comment. |
71
|
|
| Missing a Javadoc comment. |
72
|
|
| Missing a Javadoc comment. |
73
|
|
| Parameter configurationStream should be final. |
81
|
|
| Method 'isWait' is not designed for extension - needs to be abstract, final or empty. |
98
|
|
| Method 'setWait' is not designed for extension - needs to be abstract, final or empty. |
102
|
|
| Missing a Javadoc comment. |
102
|
|
| Missing a Javadoc comment. |
106
|
|
| Line is longer than 80 characters. |
111
|
|
| Missing a Javadoc comment. |
120
|
|
| Missing a Javadoc comment. |
135
|
|
| Parameter constructor should be final. |
135
|
|
| Missing a Javadoc comment. |
150
|
|
| Parameter configurationStream should be final. |
150
|
|
| Line has trailing spaces. |
151
|
|
| Redundant throws: 'SecurityException' is unchecked exception. |
151
|
|
| Line is longer than 80 characters. |
180
|
|
| '-' should be on a new line. |
180
|
|
| Missing a Javadoc comment. |
191
|
|
| Parameter digester should be final. |
191
|
|
| Parameter node should be final. |
191
|
|
| Method 'sendMessage' is not designed for extension - needs to be abstract, final or empty. |
201
|
|
| Parameter userId should be final. |
201
|
|
| Parameter message should be final. |
201
|
|
| Line is longer than 80 characters. |
202
|
|
| Method 'receiveMessage' is not designed for extension - needs to be abstract, final or empty. |
216
|
|
| Parameter userId should be final. |
216
|
|
| Parameter message should be final. |
216
|
|
| Missing a Javadoc comment. |
238
|
|
| Parameter userId should be final. |
238
|
|
| Parameter message should be final. |
238
|
|
| Missing a Javadoc comment. |
252
|
|
| Parameter configuration should be final. |
252
|
|
| Parameter unique should be final. |
253
|
|
| Missing a Javadoc comment. |
261
|
|
| Parameter userId should be final. |
261
|
|
| Parameter message should be final. |
261
|
|
| Method 'disconnectUser' is not designed for extension - needs to be abstract, final or empty. |
286
|
|
| Parameter userId should be final. |
286
|
|
| Line is longer than 80 characters. |
287
|
|
| Method 'unregisterUser' is not designed for extension - needs to be abstract, final or empty. |
295
|
|
| Parameter userId should be final. |
295
|
|
| Must have at least one statement. |
302
|
|
| Method 'run' is not designed for extension - needs to be abstract, final or empty. |
313
|
snifos/server/test/DummyServer.java
| Error | Line |
|---|
|
| Line does not match expected header line of 'AI Soccer Project - network gaming environment for AI warriors.'. |
1
|
|
| Missing a Javadoc comment. |
34
|
|
| Missing a Javadoc comment. |
35
|
|
| Method 'getMessage' is not designed for extension - needs to be abstract, final or empty. |
41
|
|
| Method 'getUserId' is not designed for extension - needs to be abstract, final or empty. |
49
|
|
| Method 'sendMessage' is not designed for extension - needs to be abstract, final or empty. |
57
|
|
| Parameter userId should be final. |
57
|
|
| 'userId' hides a field. |
57
|
|
| Parameter message should be final. |
57
|
|
| 'message' hides a field. |
57
|
|
| Parameter userId should be final. |
65
|
|
| 'userId' hides a field. |
65
|
|
| Parameter message should be final. |
65
|
|
| 'message' hides a field. |
65
|
|
| Parameter userId should be final. |
72
|
|
| 'userId' hides a field. |
72
|
|
| Parameter userId should be final. |
86
|
|
| 'userId' hides a field. |
86
|
|
| Line has trailing spaces. |
87
|
|
| Line contains a tab character. |
87
|
